feat: add tooltip for definitions #2

Merged
kulgavy merged 7 commits from ilyakulhavy/definitions-helpers into main 2021-05-18 15:33:01 +00:00
kulgavy commented 2021-05-15 23:10:18 +00:00 (Migrated from github.com)

@backmeupplz need help with "unprocessed meat" and "seafood" definitions.

@backmeupplz need help with "unprocessed meat" and "seafood" definitions.
backmeupplz (Migrated from github.com) reviewed 2021-05-15 23:10:18 +00:00
backmeupplz commented 2021-05-16 00:42:45 +00:00 (Migrated from github.com)

Hm, this PR looks a bit overcomplicated for a simple tooltip. Maybe we can try to use a third-party tooltip or even one built-in to browsers?

Hm, this PR looks a bit overcomplicated for a simple tooltip. Maybe we can try to use a third-party tooltip or even one built-in to browsers?
backmeupplz (Migrated from github.com) requested changes 2021-05-16 16:06:23 +00:00
@ -7,13 +7,19 @@ import Root from 'components/Root'
import Footer from 'components/Footer'
backmeupplz (Migrated from github.com) commented 2021-05-16 16:05:06 +00:00

Please, don't add ; across this project.

Please, don't add `;` across this project.
@ -0,0 +1,39 @@
import { classnames } from 'classnames/tailwind'
backmeupplz (Migrated from github.com) commented 2021-05-16 16:04:06 +00:00

Let's use type here instead

Let's use `type` here instead
backmeupplz (Migrated from github.com) commented 2021-05-16 16:05:23 +00:00

Let's get rid of all ; here as well

Let's get rid of all `;` here as well
@ -52,7 +53,7 @@ const Subscription: FC<SubscriptionProps> = ({ tier }) => {
<img className={image} src={`images/${tier.title}.png`} alt="avatar" />
backmeupplz (Migrated from github.com) commented 2021-05-16 16:04:28 +00:00

No need to use &nbsp;, you can use {' '} if you want

No need to use `&nbsp;`, you can use `{' '}` if you want
@ -19,2 +20,3 @@
"silverTitle": "Silver",
"silverPrice": "Previous level + not eating red meat",
"silverPrice1": "Previous level + not eating",
"silverPrice2": " ",
backmeupplz (Migrated from github.com) commented 2021-05-16 16:05:56 +00:00

Let's do this for UA as well

Let's do this for `UA` as well
backmeupplz commented 2021-05-17 13:24:41 +00:00 (Migrated from github.com)

I guess I'm not fast enough to review the PR :) please, resolve the merge conflict and incorporate German as well. Thank you!

I guess I'm not fast enough to review the PR :) please, resolve the merge conflict and incorporate German as well. Thank you!
backmeupplz commented 2021-05-18 15:32:57 +00:00 (Migrated from github.com)

Thank you a lot!

Thank you a lot!
Sign in to join this conversation.
No description provided.