backmeupplz/banofbot
Watch
1
0
Code Issues Pull requests Projects Releases Wiki Activity Actions

WIP: Avoid duplication vote #60

Closed
d1msdale wants to merge 1 commit from patch-1 into master
pull from: patch-1
merge into: backmeupplz:master
Conversation 0 Commits 1 Files changed 1 +4 -2
d1msdale commented 2024-03-20 09:50:48 +00:00 (Migrated from github.com)
Copy link

Sometime when you couple of times click for voting - your vote could be duplicated. Current logic doesn't check voter for unique. I added check for this. Also I have suspicious that should change checking from _id to id in all cases, because by mongo logic '_id' and 'id' are different fields an there could be potential collision. By this reason PR now in draft.

Sometime when you couple of times click for voting - your vote could be duplicated. Current logic doesn't check voter for unique. I added check for this. Also I have suspicious that should change checking from _id to id in all cases, because by mongo logic '_id' and 'id' are different fields an there could be potential collision. By this reason PR now in draft.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

   
dependencies
Pull requests that update a dependency file

  
duplicate

   
enhancement

   
help wanted

   
invalid

   
javascript
Pull requests that update javascript code

  
question

   
wontfix
No labels
bug
dependencies
duplicate
enhancement
help wanted
invalid
javascript
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
backmeupplz/banofbot!60
No description provided.