iOS: re-press the OfflineSeries removal confirmation when hosted CI drops the tap (#99) #30

Merged

backmeupplz merged 3 commits from fix/99-offline-series-removal into main

2026-10-13 05:50:59 +00:00

backmeupplz commented

2026-10-13 03:18:47 +00:00

(Migrated from github.com)

Fixes agentboard #99 (https://agentboard.icefish-betta.ts.net/#99).

Cause

OfflineSeries.testDetailRemovalAndRepeatedChangesPreserveSurvivingPixelAnchor failed at line 71 on run 38328812201 (attempt 2). The failure-time UI hierarchy in that run's xcresult shows the "Remove the download of “Series title 107”?" confirmation popover still open with its "Remove download" button, and the detail button still labelled "Remove download". The 5s wait polled normally (five reads, no stalled snapshots), so this was not a slow redraw: the 50ms confirmation tap was synthesized but never committed, the same hosted iOS 26 dropped-touch behaviour seen in #82.

Fix

After the confirmation appears, send a deliberate 0.1s press and wait for "Download"; press again (up to 3 attempts) only while the confirmation dialog is still showing. A committed removal that is merely slow to redraw is never confirmed twice, it just gets more time. The test still requires the detail screen to show "Download" (removal really happened) and every pixel-anchor check is unchanged. The final assertion now carries app.debugDescription.

Fixes agentboard #99 (https://agentboard.icefish-betta.ts.net/#99). ## Cause `OfflineSeries.testDetailRemovalAndRepeatedChangesPreserveSurvivingPixelAnchor` failed at line 71 on run 38328812201 (attempt 2). The failure-time UI hierarchy in that run's xcresult shows the "Remove the download of “Series title 107”?" confirmation popover **still open** with its "Remove download" button, and the detail button still labelled "Remove download". The 5s wait polled normally (five reads, no stalled snapshots), so this was not a slow redraw: the 50ms confirmation tap was synthesized but never committed, the same hosted iOS 26 dropped-touch behaviour seen in #82. ## Fix After the confirmation appears, send a deliberate 0.1s press and wait for "Download"; press again (up to 3 attempts) **only while the confirmation dialog is still showing**. A committed removal that is merely slow to redraw is never confirmed twice, it just gets more time. The test still requires the detail screen to show "Download" (removal really happened) and every pixel-anchor check is unchanged. The final assertion now carries `app.debugDescription`.