Borodutch/fondu-backend
Watch
1
0
Code Issues Pull requests Projects Releases Wiki Activity Actions

erc721 contract builder #8

Merged
Frozo13 merged 3 commits from erc721-contract-builder into main 2021-06-09 17:05:03 +00:00
Conversation 4 Commits 3 Files changed 5 +33 -11
Frozo13 commented 2021-06-05 14:29:52 +00:00 (Migrated from github.com)
Copy link
No description provided.
stasnepomn (Migrated from github.com) requested changes 2021-06-08 15:53:07 +00:00
src/helpers/templateBuilder.ts
@ -0,0 +1,13 @@
import { readFileSync } from 'fs'
stasnepomn (Migrated from github.com) commented 2021-06-08 15:52:11 +00:00
Copy link

Уточни тип интерфейсом

Уточни тип интерфейсом
stasnepomn (Migrated from github.com) commented 2021-06-08 15:52:42 +00:00
Copy link

Используй TS примитивы (string вместо String)

Используй TS примитивы (string вместо String)
stasnepomn (Migrated from github.com) requested changes 2021-06-08 15:56:25 +00:00
src/helpers/templateBuilder.ts
@ -0,0 +1,13 @@
import { readFileSync } from 'fs'
stasnepomn (Migrated from github.com) commented 2021-06-08 15:56:21 +00:00
Copy link

По возможности всегда используй константы

По возможности всегда используй константы
stasnepomn (Migrated from github.com) requested changes 2021-06-08 15:57:56 +00:00
src/helpers/templateBuilder.ts
@ -0,0 +1,13 @@
import { readFileSync } from 'fs'
stasnepomn (Migrated from github.com) commented 2021-06-08 15:57:52 +00:00
Copy link

Почему мы получаем на входе строку, и конвертируем её в строку? (: Наверное, поэтому и стоит использовать примитивы от TS :)

Почему мы получаем на входе строку, и конвертируем её в строку? (: Наверное, поэтому и стоит использовать примитивы от TS :)
stasnepomn (Migrated from github.com) approved these changes 2021-06-09 17:02:29 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
stasnepomn
Labels
Clear labels   
bug
Something isn't working

  
documentation
Improvements or additions to documentation

  
duplicate
This issue or pull request already exists

  
enhancement
New feature or request

  
good first issue
Good for newcomers

  
help wanted
Extra attention is needed

  
invalid
This doesn't seem right

  
question
Further information is requested

  
wontfix
This will not be worked on

No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
Borodutch/fondu-backend!8
No description provided.